Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add undici to glossary #43327

Merged
merged 1 commit into from
Jun 9, 2022
Merged

doc: add undici to glossary #43327

merged 1 commit into from
Jun 9, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 6, 2022 •
edited
Loading

This pr adds undici to node's vocabulary.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 6, 2022
tniessen
tniessen reviewed Jun 6, 2022
View reviewed changes
glossary.md Show resolved Hide resolved
@F3n67u F3n67u force-pushed the glossary-unidici branch from 50ec404 to 54f5019 Compare June 7, 2022 01:04
@F3n67u F3n67u requested review from Trott, tniessen and lpinca June 7, 2022 06:07
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43327
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/2464217211

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 8, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43327
✔  Done loading data for nodejs/node/pull/43327
----------------------------------- PR info ------------------------------------
Title      doc: add undici to glossary (#43327)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:glossary-unidici -> nodejs:master
Labels     doc
Commits    1
 - doc: add undici to glossary
Committers 1
 - Feng Yu 
PR-URL: https://github.com/nodejs/node/pull/43327
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43327
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 06 Jun 2022 07:58:04 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43327#pullrequestreview-996859465
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43327#pullrequestreview-997968145
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43327#pullrequestreview-1000248554
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43327#pullrequestreview-1000316703
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2464371651

@F3n67u @Trott
doc: add undici to glossary
c977ad6 
PR-URL: nodejs#43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the glossary-unidici branch from 54f5019 to c977ad6 Compare June 9, 2022 00:22
@Trott
Copy link
Member

Trott commented Jun 9, 2022

Landed in c977ad6

@Trott Trott merged commit c977ad6 into nodejs:master Jun 9, 2022
@F3n67u F3n67u deleted the glossary-unidici branch June 9, 2022 00:53
@F3n67u
Copy link
Member Author

F3n67u commented Jun 9, 2022

Landed in c977ad6

thanks for landing this pr

danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@F3n67u @danielleadams
doc: add undici to glossary
bc57aa2 
PR-URL: #43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
doc: add undici to glossary
b34a9f9 
PR-URL: #43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
doc: add undici to glossary
d558b3c 
PR-URL: #43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: add undici to glossary
92b8f4b 
PR-URL: #43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: add undici to glossary
f7bfa10 
PR-URL: #43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: add undici to glossary
44987b7 
PR-URL: nodejs/node#43327
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@F3n67u @nodejs-github-bot @Trott @lpinca @tniessen @aduh95 @marsonya